mirrors/vaultwarden
Watch
1
0
Fork
You've already forked vaultwarden
 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-08-23 04:24:57 -04:00
Code Issues Releases Packages Wiki Activity
3,065 commits 5 branches 87 tags 53 MiB
Commit graph

3,065 commits

This branch
This branch
All branches
Author SHA1 Message Date
Mathijs van Veluw
2b824e8096
 		Updated security readme (#4892) 
Update the security readme with a new GPG security key and some small
other changes.

Signed-off-by: BlackDex <black.dex@gmail.com>
 2024-08-24 18:59:27 +02:00
Mathijs van Veluw
059661be48
 		Update crates (GHSA-wq9x-qwcq-mmgf) (#4889) 
- Updated crates
- Fixed MSRV to actually be N-2
- Changed some features to use the `dep:` prefix.
  This is needed for edition-2024 anyway although that will be a while before we can use that.

Signed-off-by: BlackDex <black.dex@gmail.com>
 2024-08-23 22:06:11 +02:00
Mathijs van Veluw
0f3f97cc76
 		Update issue template (#4882) 
Updated the issue template a bit regarding some remarks in the previous pr.

Also made it so that collapsing all items will show all the specific
item id's instead of there types. Easy for editiing :).

Signed-off-by: BlackDex <black.dex@gmail.com>
 2024-08-23 22:03:57 +02:00
philomathic_life
aa0fe7785a
 		Remove version from server config info (#4885) 2024-08-22 21:42:30 +02:00
Timshel
65d11a9720
 		Switch to Whitelisting in .dockerignore (#4856) 2024-08-21 21:59:17 +02:00
Mathijs van Veluw
c722006385
 		Fix Login with device (#4878) 
Fixed an issue with login with device for the new Bitwrden Beta clients.
They seem to not support ISO8601 milli date/time, only micro.

Also updated the device display names to match Upstream and added the
CLI devices which were missing.

Signed-off-by: BlackDex <black.dex@gmail.com>
 2024-08-21 21:57:52 +02:00
Stefan Melmuk
aaab7f9640
 		remove overzealous sanity check (#4879) 
when cloning an item from an organization to the personal vault
the client sends the collection id of the cloned item
 2024-08-21 21:54:13 +02:00
Mathijs van Veluw
cbdb5657f1
 		Update issue template (#4876) 
Updated the issue template to use a form and guide users to provide all
information useful to troublshoot issues

Als updated links to prefer the usage of GitHub Discussions.

Signed-off-by: BlackDex <black.dex@gmail.com>
 2024-08-20 21:25:28 +02:00
Mathijs van Veluw
669b9db758
 		Fix Vaultwarden Admin page error messages (#4869) 
Since the change to camelCase variables the error messages in the
Vaultwarden Admin were not shown correctly anymore.

This PR fixes this by changing the case of the json key's.
Also updated the save and delete of the config to provide a more
descriptive error instead of only `Io` or which ever other error might
occure.

Fixes #4834
 2024-08-18 21:04:22 +02:00
Timshel
3466a8040e
 		Remove unecessary email normalization (#4840) 2024-08-17 22:48:59 +02:00
Daniel
7d47155d83
 		Update email footer padding values (#4838) 
- looks better, the Github logo was too close to the bottom
- also fix a minor issue in the new device log in HTML template
 2024-08-17 22:48:10 +02:00
Mathijs van Veluw
9e26014b4d
 		Fix manager in web-vault v2024.6.2 for collections (#4860) 
The web-vault v2024.6.2 we use needs some extra information to allow
managers to actually be able to manage collections.

The v2024.6.2 web-vault has somewhat of a mixture of the newer roles and
older manager roles. To at least fix this for the web-vault we bundle
these changes will make the manager able to manage.

For future web-vaults we would need a lot more changes to be done to fix
this in a better way though.

Fixes #4844
 2024-08-15 12:36:00 +02:00
Mathijs van Veluw
339612c917
 		Fix Duo Redirect not using path (#4862) 
The URL crate treats `https://domain.tld/path` differently then
`https://domain.tld/path/` the latter will make sure a `.join()` will
append the given path instead of using the base as a relative path.

Fixes #4858
 2024-08-15 12:29:51 +02:00
Mathijs van Veluw
9eebbf3b9f
 		Update GitHub Action Workflows (#4849) 2024-08-13 12:52:07 +02:00
Mathijs van Veluw
b557c11724
 		Fix data disclosure on organization endpoints (#4837) 1.32.0 
- All users were able to request organizational details from any org,
  even if they were not a member (anymore).
  Now it will check if that user is a member of the org or not.
- The `/organization/<uuid>/keys` endpoint returned also the private keys.
  This should not be the case. Also, according to the upstream server
  code the endpoint changed, but the clients do not seem to use it.
  I added it anyway just in case they will in the future.
- Also require a valid login before being able to retreve those org
  keys. Upstream does not do this, but i see no reason why not.

Fixes: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-39925
 2024-08-11 19:39:56 +02:00
Daniel
a1204cc935
 		Update Rust to 1.80.1 (#4831) 2024-08-09 11:52:56 +02:00
Mathijs van Veluw
1ea511cbfc
 		Updated web-vault to v2024.6.2b (#4826) 2024-08-08 17:04:04 +02:00
Mathijs van Veluw
2e6a6fa39f
 		Update crates, web-vault and fixes (#4823) 
* Update crates, web-vault and fixes

- Updated crates
- Updated web-vault to v2024.6.2
  This version is currently the latest version compatible with our API implementation.
  For newer versions we need more code updates to make it compatible.
  Thanks to @stefan0xC this version fixes #4628
- Added a small fix to prevent errors in the Vaultwarden and Client logs.
  The v2024.6.2 web-vault calls an endpoint with invalid arguments.
  If this happens we ignore the call and just return an Ok.
- Added the bulk-collection endpoint (Though not yet available in v2024.6.2)

Fixes #4628

* Prevent bulk remove collections to work
 2024-08-07 22:46:03 +02:00
Daniel
e7d5c17ff7
 		Fix mail::send_incomplete_2fa_login panic issue (#4792) 
- fixes https://github.com/dani-garcia/vaultwarden/issues/4528
 2024-08-07 22:45:41 +02:00
Daniel
a7be8fab9b
 		Remove lowercase conversion for featureStates (#4820) 
- needed to match Bitwarden, some of the feature flags might have uppercase characters (for example: ```PM-4154-bulk-encryption-service```)
 2024-08-07 21:55:58 +02:00
Stefan Melmuk
39d4d31080
 		make access_all optional (#4812) 
* make access_all optional

* use #[serde(default)] instead of unwrapping
 2024-08-01 19:45:42 +02:00
Mathijs van Veluw
c28246cf34
 		Secure send file uploads (#4810) 
Currently there are no checks done during the actual upload of the file of a send item.
This PR adds several checks to make sure it only accepts the correct uploads.
 2024-07-31 15:24:15 +02:00
Daniel
d7df0ad79e
 		Rewrite the Push Notifications section in the configuration template (#4805) 
- also update the European Union related information for a working setup
- fixes https://github.com/dani-garcia/vaultwarden/issues/4609
 2024-07-30 19:42:56 +02:00
Stefan Melmuk
7c8ba0c232
 		fix issue with adding ciphers to organizations on native ios app (#4800) 
* add organizationID alias for native ios

* add reverse sanity check
 2024-07-30 11:50:05 +02:00
Daniel
d335187172
 		Update rust-toolchain.toml to 1.80.0 (#4784) 2024-07-25 21:23:09 +02:00
Timshel
f858523d92
 		Duo: use the formatted db email (#4779) 2024-07-25 20:25:44 +02:00
Mathijs van Veluw
529c39c6c5
 		Update Rust, Crates and GHA (#4783) 
- Update Rust to v1.80.0
- Updated GitHub Actions
- Updated crates
 2024-07-25 20:24:27 +02:00
Mathijs van Veluw
b428481ac0
 		Allow to increase the note size to 100_000 (#4772) 
This PR adds a config option to allow the note size to increase to 100_000, instead of the default 10_000.
Since this might cause issues with the clients (in the future), and will cause issues with importing into a Bitwarden server, i added warnings regarding this.

Closes #3168
 2024-07-24 21:49:01 +02:00
0x0fbc
b4b2701905
 		Add support for MFA with Duo's Universal Prompt (#4637) 
* Add initial working Duo Universal Prompt support.

* Add db schema and models for Duo 2FA state storage

* store duo states in the database and validate during authentication

* cleanup & comments

* bump state/nonce length

* replace stray use of TimeDelta

* more cleanup

* bind Duo oauth flow to device id, drop redundant device type handling

* drop redundant alphanum string generation code

* error handling cleanup

* directly use JWT_VALIDITY_SECS constant instead of copying it to DuoClient instances

* remove redundant explicit returns, rustfmt

* rearrange constants, update comments, error message

* override charset on duo state column to ascii for mysql

* Reduce twofactor_duo_ctx state/nonce column size in postgres and maria

* Add fixes suggested by clippy

* rustfmt

* Update to use the make_http_request

* Don't handle OrganizationDuo

* move Duo API endpoint fmt strings out of macros and into format! calls

* Add missing indentation

Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>

* remove redundant expiry check when purging Duo contexts

---------

Co-authored-by: BlackDex <black.dex@gmail.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
 2024-07-24 16:50:35 +02:00
Timshel
de66e56b6c
 		Allow to override log level for specific target (#4305) 2024-07-24 16:49:03 +02:00
Stefan Melmuk
ecfebaf3c7
 		allow re-invitations of existing users (#4768) 
* allow re-invitations of existing users

* auto-accept existing user if mail is disabled

Apply suggestions from code review

Co-authored-by: Mathijs van Veluw <black.dex@gmail.com>

---------

Co-authored-by: Mathijs van Veluw <black.dex@gmail.com>
 2024-07-24 00:32:46 +02:00
Daniel
0e53f58288
 		Fix Dockerfile linter warnings (#4763) 
- they seem to have started appearing with buildx v0.16.0
- skip lint check for FromPlatformFlagConstDisallowed and RedundantTargetPlatform
 2024-07-24 00:28:07 +02:00
Daniel
bc7ceb2ee3
 		Update crates & fix crate vulnerability (#4771) 
- fixes GHSA-q445-7m23-qrmw by updating openssl to version 0.10.66
 2024-07-24 00:26:39 +02:00
Mathijs van Veluw
b27e6e30c9
 		Fix Email 2FA login on native app (#4762) 2024-07-17 16:20:54 +02:00
Mathijs van Veluw
505b30eec2
 		Fix for RSA Keys which are read only (#4744) 
* Fix for RSA Keys which are read only

Sometimes an RSA Key file could be read only.
We currently failed because we also wanted to write.
Added an extra check if the file exists already and is not 0 in size.
If it does already exists and is larger then 0, then open in read only
mode.

Fixes #4644

* Updated code to work atomically

- Changed the code to work atomically
- Also show the alert generated from `Io`

* Fix spelling
 2024-07-17 12:59:22 +02:00
Mathijs van Veluw
54bfcb8bc3
 		Update admin interface (#4737) 
- Updated datatables
- Set Cookie Secure flag if the connection is https
- Prevent possible XSS via Organization Name
  Converted all `innerHTML` and `innerText` to the Safe Sink version `textContent`
- Removed `jsesc` function as handlebars escapes all these chars already and more by default
 2024-07-12 22:59:48 +02:00
Daniel García
035f694d2f
 		Improved HTTP client (#4740) 
* Improved HTTP client

* Change config compat to use auto, rename blacklist

* Fix wrong doc references
 2024-07-12 22:33:11 +02:00
Coby Geralnik
a4ab014ade
 		Fix bug where secureNotes is empty (#4730) 2024-07-10 22:13:55 +02:00
Calvin Li
6fedfceaa9
 		chore: Dockerfile to Remove port 3012 (#4725) 2024-07-10 18:40:29 +02:00
Stefan Melmuk
8e8483481f
 		use a custom plan of enterprise tier to fix limits (#4726) 
* use a custom plan of enterprise tier to fix limits

* set maxStorageGb limit to max signed int value
 2024-07-10 17:25:41 +02:00
Mathijs van Veluw
d04b94b77d
 		Some fixes for emergency access (#4715) 1.31.0 
- Add missing `Headers` parameter for some functions
   This allowed any request from allowing these endpoints by not validating the user correctly.
 - Changed the functions to retreive the emergency access record by
   using the user uuid which calls the endpoint, instead of validating afterwards.
   This is more secure and prevents the need of an if check.
 2024-07-08 23:39:22 +02:00
Mathijs van Veluw
247d0706ff
 		Update crates and web-vault (#4714) 
- Updated the crates
   Removed the patch for mimalloc
 - Updated the web-vault to v2024.5.1b

The reason for not updating to v2024.6.x is that there are several items
not working correctly or need some more research.
 2024-07-08 23:27:48 +02:00
Daniel
0e8b410798
 		Switch registry cache compression algorithm to zstd (#4704) 
- faster builds than with gzip (the default)
 2024-07-08 23:27:39 +02:00
Stefan Melmuk
fda77afc2a
 		add group support for Cipher::get_collections() (#4592) 
* add group support for Cipher::get_collections()

join group infos assigned to a collection to check
whether user has been given access to all collections via any group
or they have access to a specific collection via any group membership

* fix Collection::is_writable_by_user()

prevent side effects if groups are disabled

* differentiate the /collection endpoints

* return cipherDetails on post_collections_update()

* add collections_v2 endpoint
 2024-07-04 20:28:19 +02:00
Daniel
d9835f530c
 		Remove duplicate registry step (#4703) 2024-07-04 19:57:49 +02:00
Mathijs van Veluw
bd91964170
 		Fix duplicate folder creations during import (#4702) 
During import you are able to select an existing folder, or with
Bitwarden exports it can contain existing folders already. In either
case it didn't matter, we always created new folders.

Bitwarden uses the same UUID of the selected or existing folders if they
are already there.

This PR fixes this by using the same behaviour.

Fixes #4700
 2024-07-04 19:57:32 +02:00
Mathijs van Veluw
d42b264a93
 		Fix collections and native app issue (#4685) 
Collections were not visible in the organization view.
This was because the `flexibleCollections` was set to `true`

Found an issue with loading some old created Secure Notes which had `{}` or `{"type":null}` as there `data` value.
This isn't allowed. When detected, replace it with `{"type":0}`

Fixes #4682
Fixes #4590
 2024-07-03 21:11:04 +02:00
Daniel García
a4c7fadbf4
 		Change some missing PascalCase keys (#4671) 2024-06-24 21:17:59 +02:00
Daniel
8e2a87fd79
 		Remove mimalloc workaround (#4606) 
- libatomic linking for armv6 has been fixed in 992c9da4c5
 2024-06-24 19:44:21 +02:00
Daniel García
4233dbf3db
 		Fix cipher creation on new android app (#4670) 2024-06-24 19:44:06 +02:00